search

ShokoAnime / ShokoServer

Repository for Shoko Server.
https://shokoanime.com/
MIT License
408 stars 74 forks source link

Login rate limiter #573

Closed Stonedestroyer closed 7 years ago

Stonedestroyer commented 7 years ago

LOG FILE

https://github.com/japanesemediamanager/ShokoServer/files/750183/2017-02-03.txt

Description

Trying to switch database and each time it logs into AniDB getting me banned.

STEPS TO REPRODUCE

Keep switching database and logs you in each time, I think shutdown is affected by same thing.

Cazzar commented 7 years ago

Ultimately as well, the login prompt shouldn't appear on a banned response.

bond4u commented 7 years ago

Is this about "anidb login failed" popup? It pop up way too often. I just confirmed my login and minute later it pops up again (no ban). I think it pop ups on any (connection) error, not just failed login.

ElementalCrisis commented 7 years ago

Is still an issue on Daily?

Cazzar commented 7 years ago

I would say this is fixed, as the login command is forced through the ratelimiter. As for the login popup stuff, #644

bigretromike commented 7 years ago

Fresh install with 3.8, fresh db. After scanning my database I end up with ban, that is now 2 days long... wtf

Cazzar commented 7 years ago

@bigretromike adding logs would be useful, as I rehashed my entire library after all the ratelimit code was modified, and have not had this.

ElementalCrisis commented 7 years ago

Keep in mind that failing a login I believe twice gets you banned as well. But I just tested logging in 10+ times and had no issues.

bigretromike commented 7 years ago

Need full or the ban part?

On August 12, 2017 5:25:53 PM GMT+02:00, Cayde Dixon notifications@github.com wrote:

@bigretromike adding logs would be useful, as I rehashed my entire library after all the ratelimit code was modified, and have not had this.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/ShokoAnime/ShokoServer/issues/573#issuecomment-321987911

hidden4003 commented 7 years ago

I beleive this can be closed, could've been leech protect on anidb side kicking in as all depends on the order you added anime to db.

Also you didn't specify UDP or HTTP ban as those are different. Anyways reopen as a separate issue in case it happens again.