search

ShokoAnime / ShokoServer

Repository for Shoko Server.
https://shokoanime.com/
MIT License
404 stars 74 forks source link

Voting for episode is not being send to AniDB #803

Closed bigretromike closed 2 months ago

bigretromike commented 5 years ago

Voted on many-many episodes, non is send to anidb.

My profile: https://anidb.net/user/687959/vote/?do=episode&epp=30

No single vote on episode is there, and I just voted on few to test it.

Should it send data or episode voting is local and no-one notice it ? because starting fresh shoko would nuke all votes that way.

its been confirma by @Baine that this is not send anywhere.

bigretromike commented 5 years ago

@da3dsoul while you on your done-shit-while-in-bed code-spree, it would be good for both shoko and nakamori that we could send our vote to anidb and not store them only in shoko cache.

da3dsoul commented 4 years ago

Closing this, for one because it's been known for years, but mostly because I was in the process of fixing it anyway

bigretromike commented 4 years ago

so maybe close it when it's working ?

bigretromike commented 4 years ago

so maybe close it when it's working ?

bigretromike commented 4 years ago

so maybe close it when it's working ?

da3dsoul commented 4 years ago

Haha GitHub is having issues. It's fixed, but not implemented into running code. I'm closing it because I see no need to look at it when it's finished

bigretromike commented 4 years ago

thats what milestone are for but do what you want. I just would like to vote from shoko on episode and that was the issue.

da3dsoul commented 4 years ago

Don't worry, I'll definitely tell you when it's ready to test

bigretromike commented 3 years ago

Was this finished ? because there was no feedback

da3dsoul commented 3 years ago

"It's fixed, but not implemented into running code. I'm closing it because I see no need to look at it when it's finished"

bigretromike commented 3 years ago

@da3dsoul

Don't worry, I'll definitely tell you when it's ready to test

How about telling when it will be in implemented into running code?

da3dsoul commented 3 years ago

I think that was a misunderstanding in language. That's not me giving an expectation of timing. That's me saying that I will notify when it is already implemented. It's part of an AniDB rewrite. I'm currently busy with other things, so it was put on hold. The queue needs to be redesigned to allow the AniDB rewrite to be how I want it

bigretromike commented 3 years ago

So please leave it open, as its not done. Its still something to be done then.

bigretromike commented 3 years ago

@da3dsoul I saw hoping it was a matter of uncomment this: https://github.com/ShokoAnime/ShokoServer/blob/d6efa585dad8d85c83c68414e92ca9e6e390a146/Shoko.Server/API/v3/Models/Shoko/Episode.cs#L170

revam commented 1 year ago

Will look at it or bug @da3dsoul about it tomorrow about it. We're past the anidb rewrite now.

ElementalCrisis commented 10 months ago

@revam following up.

da3dsoul commented 10 months ago

I honestly don't remember, but it probably works now and needs API or something

revam commented 10 months ago

@da3dsoul you removed the command to do it. it needs to be re-added after the anidb rewrite.

harshithmohan commented 2 months ago

Fixed in v3 API. EDIT: Now fixed in v2 API too on the daily