ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
391 stars 75 forks source link

Recommendations to Watch/Download #983

Open bigretromike opened 7 years ago

bigretromike commented 7 years ago

Non is shown, event after hiting "Get Missing Data Now" no data populate this tab on Dashboard

Is this because bittorrent functionality was removed or intended ?

v3.8.0.1021

bigretromike commented 7 years ago

This could be related with fact that clicking "Get Missing Data Now" don't queue any commands.

bigretromike commented 7 years ago

Also when going thru Recommandation at Utility tab, and clicking "Get missing data" I get this error:

[[2017-09-19 15:50:09:008] Error|BackgroundWorker.OnDoWork => MissingEpisodesControl.workerFiles_DoWork => Utils.ShowErrorMessage System.AggregateException: One or more errors occurred. ---> System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown. at System.String.CreateStringFromEncoding(Byte bytes, Int32 byteLength, Encoding encoding) at System.Text.UTF8Encoding.GetString(Byte[] bytes, Int32 index, Int32 count) at System.Net.Http.HttpContent.ReadBufferedContentAsString() at System.Net.Http.HttpContent.d63`2.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Nancy.Rest.Client.Rest.SmallWebClient.d0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Nancy.Rest.Client.ClientFactory.<>cDisplayClass2_0.<b0>d.MoveNext() --- End of inner exception stack trace --- at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification) at Nancy.Rest.Client.ClientFactory.DoSyncClient(Object dexp, MethodDefinition def, IWebProxy proxy, Object[] parameters) at System.Dynamic.UpdateDelegates.UpdateAndExecute8[T0,T1,T2,T3,T4,T5,T6,T7,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4, T5 arg5, T6 arg6, T7 arg7) at Nancy.Rest.Client.ClientFactory.<>cDisplayClass1_1`1.b16(Object a, Object b, Object c, Object d) at System.Dynamic.UpdateDelegates.UpdateAndExecute5[T0,T1,T2,T3,T4,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4) at CallSite.Target(Closure , CallSite , Object , Int32 , Boolean , Boolean , Int32 ) at System.Dynamic.UpdateDelegates.UpdateAndExecute5[T0,T1,T2,T3,T4,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3, T4 arg4) at ActLike_IShokoServer_c4908871d66c456ebee5c50abf20aece.GetMissingEpisodes(Int32 userID, Boolean onlyMyGroups, Boolean regularEpisodesOnly, Int32 airingState) at Shoko.Desktop.UserControls.MissingEpisodesControl.workerFiles_DoWork(Object sender, DoWorkEventArgs e) in C:\projects\jmmclient\Shoko.Desktop\UserControls\MissingEpisodesControl.xaml.cs:line 188 ---> (Inner Exception #0) System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown. at System.String.CreateStringFromEncoding(Byte bytes, Int32 byteLength, Encoding encoding) at System.Text.UTF8Encoding.GetString(Byte[] bytes, Int32 index, Int32 count) at System.Net.Http.HttpContent.ReadBufferedContentAsString() at System.Net.Http.HttpContent.d63`2.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Nancy.Rest.Client.Rest.SmallWebClient.d0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Nancy.Rest.Client.ClientFactory.<>c__DisplayClass2_0.<b__0>d.MoveNext()<---

[2017-09-19 15:50:09:055] Error|ExceptionWrapper.TryCatchWhen => Dispatcher.CatchException => App.Current_DispatcherUnhandledException System.NullReferenceException: Object reference not set to an instance of an object. at Shoko.Desktop.UserControls.MissingEpisodesControl.workerFiles_RunWorkerCompleted(Object sender, RunWorkerCompletedEventArgs e) in C:\projects\jmmclient\Shoko.Desktop\UserControls\MissingEpisodesControl.xaml.cs:line 174 at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

da3dsoul commented 7 years ago

Buy more RAM! Sorry that's become an ongoing joke. I'll look at it

bigretromike commented 7 years ago

I can't its over 9000 already.

da3dsoul commented 7 years ago

Haha mine passed 9000 long ago, and it's not even in its final form

ElementalCrisis commented 2 years ago

Is this still an issue @bigretromike?

harshithmohan commented 2 years ago

Still an issue but only on desktop. ​/api​/v3/Series​/AniDB​/RecommendedForYou works perfectly so webui should be able to get the data (in the future, whenever implemented)

revam commented 2 years ago

It will only recommend series to watch though. Which is fine, since shoko doesn't support downloading stuff besides metadata.

ElementalCrisis commented 9 months ago

@harshithmohan are we using that endpoint? My Recommended Anime section is empty.

harshithmohan commented 9 months ago

@harshithmohan are we using that endpoint? My Recommended Anime section is empty.

Maybe because you don't use shoko? 🙃

2023-12-31_15-18

harshithmohan commented 9 months ago

It seems to be only getting "recommended" anime from locally available anime

revam commented 9 months ago

It seems to be only getting "recommended" anime from locally available anime

Because it's not a recommendation to download, it's a recommendation to watch, and yes it's only based off of local AniDB data.

bigretromike commented 9 months ago

Can't we get recommendation like on anidb based on watched and not only locally stored ?

revam commented 9 months ago

Can't we get recommendation like on anidb based on watched and not only locally stored ?

It's based on local watch data and local anidb data. How else would it make recommendations if it doesn't know what you like to see?

bigretromike commented 9 months ago

@revam sorry, maybe I did not understand what you had on mind by saying "local". Does it recommands series that you don't have LOCAL on HDD also ( or never added to shoko before) ? if so then great.

revam commented 9 months ago

You don't need a Shoko series for the AniDB anime, but you do need to have the AniDB anime data in your local database. there are many ways that shoko can passively acquire the data, but the most common (I will assume) is if the database admin have enabled pulling in related anime data. Another way is when updating the calendar.

ElementalCrisis commented 9 months ago

@harshithmohan and I looked into it a bit and I don't know if I missed it originally but AniDB does have an endpoint to pull rando, similar and hot recs.

https://wiki.anidb.net/HTTP_API_Definition#Random_Recommendation

We should look into incorporating this into the future for this section on the Web UI.

However, for now we'll leave it as is as I would want to redesign the UI for a feature like this.