search

ShokoAnime / Shokofin

Repository for Shokofin, a plugin that brings Shoko to Jellyfin.
https://shokoanime.com
MIT License
140 stars 17 forks source link

Specials not excluded from season #37

Closed papaj-na-wrotkach closed 1 year ago

papaj-na-wrotkach commented 1 year ago

I have customized this option: image

And despite choosing this option (before creating a library) the specials show up in season: image

The specials also show up in additional season (there are 12 regular episodes and 6 specials in main season and the same 6 specials in Specials season): image

A interesting fact: despite being in Specials season... image

the first episode image

papaj-na-wrotkach commented 1 year ago

By the way, when I change Season number of a special episode it doesn't show up in main season anymore - only in Specials as Special - [title] (before the change it was like the others - 1. [title]): image

The changes are temporary though - they disappear after every metadata rescan.

revam commented 1 year ago

There was some error in the logic for when to use the assumed season number and when to use season zero. It should be fixed in https://github.com/ShokoAnime/Shokofin/commit/dad26e9848ca055d41e77744d1287677508541b3 and broadly available in the next stable release (No ETA). If you want the fix now then I will recommend using the unstable manifest, but that requires a recent daily version of Shoko Server to work at the moment, since it uses some new endpoints not available in the stable version yet.