ShokoAnime / Shokofin

Repository for Shokofin, a plugin that brings Shoko to Jellyfin.
https://shokoanime.com
MIT License
140 stars 17 forks source link

Title settings → Ordered checkbox #52

Closed fearnlj01 closed 4 months ago

fearnlj01 commented 4 months ago

I'll rebase this branch into a single commit when it's eventually ready for review, but figured it best to open a draft PR now that the html/js implementation is hopefully complete...

Unless future commits render the plugin unable to load, the client side changes should be able to be previewed (with saving/loading the settings being non-functional).

fearnlj01 commented 4 months ago

And for the sake of the curious who don't fancy delving too deep into things... The following screenshots summarise what the settings will be changing to with this PR.

image

image

revam commented 4 months ago

sorry, forgot to mention, only the options should had "main" replaced by "default", the main title we choose the selectors for will still be called the main title. :pensive:

fearnlj01 commented 4 months ago

sorry, forgot to mention, only the options should had "main" replaced by "default", the main title we choose the selectors for will still be called the main title. 😔

Realised the same thing after uploading the images... I got a little overzealous with the Find & Replace tool 🙊

revam commented 4 months ago

fast-n-dirty preview (mind the capitalization. also, every word that is not a name (e.g. Shoko, AniDB, TMDB) or the first word in the sentence should not be capitalized); image

revam commented 4 months ago

Also also, don't mention "Shokofin" at all in the config page.

fearnlj01 commented 4 months ago

For the sake of putting an image to the previous commit...

image

revam commented 4 months ago

Can you remove the lines where it says the overrides are applied even if they aren't enabled?

fearnlj01 commented 4 months ago

I've done what limited testing I can with my library and it's working as I expect at the very least.

Obviously with the quantity of changes, the plugin will have drastically different behaviour for generating titles albeit arguarbly more expected behaviour.

Hopefully the way I've done this keeps it satisfactorily easy to adapt when any additional shoko powered providers are implemented :)