Shoobx / mypy-zope

Plugin for mypy to support zope.interface
MIT License
39 stars 13 forks source link

Fix the test_samples unittest for the interface_implications.py case. #116

Closed maxinasa closed 4 months ago

maxinasa commented 4 months ago

This should fix the tests issue raised in https://github.com/Shoobx/mypy-zope/pull/115

maxinasa commented 4 months ago

Result of locally running the tests:

❯ pytest --junit-xml var/test-results/results.xml -v --cov src/mypy_zope --cov-report=term
==================================================================================================== test session starts =====================================================================================================
platform darwin -- Python 3.11.5, pytest-8.2.2, pluggy-1.5.0 -- .virtualenvs/mypy-zope-fork/bin/python
cachedir: .pytest_cache
rootdir: /Users/amaxinas/repos/others/mypy-zope-fork
plugins: cov-5.0.0
collected 42 items

tests/test_samples.py::test_samples[innerclass] PASSED                                                                                                                                                                 [  2%]
tests/test_samples.py::test_samples[interface_getattr] PASSED                                                                                                                                                          [  4%]
tests/test_samples.py::test_samples[schema_number] PASSED                                                                                                                                                              [  7%]
tests/test_samples.py::test_samples[nested_definitions] PASSED                                                                                                                                                         [  9%]
tests/test_samples.py::test_samples[incompatible_signature] PASSED                                                                                                                                                     [ 11%]
tests/test_samples.py::test_samples[schema_bool] PASSED                                                                                                                                                                [ 14%]
tests/test_samples.py::test_samples[overload_readme] PASSED                                                                                                                                                            [ 16%]
tests/test_samples.py::test_samples[impl_inheritance] PASSED                                                                                                                                                           [ 19%]
tests/test_samples.py::test_samples[impl_property] PASSED                                                                                                                                                              [ 21%]
tests/test_samples.py::test_samples[classimplements] PASSED                                                                                                                                                            [ 23%]
tests/test_samples.py::test_samples[forward_reference_to_implementer] PASSED                                                                                                                                           [ 26%]
tests/test_samples.py::test_samples[contextmanager] PASSED                                                                                                                                                             [ 28%]
tests/test_samples.py::test_samples[classimplements_broken_iface] PASSED                                                                                                                                               [ 30%]
tests/test_samples.py::test_samples[schema_field_outside_inteface] PASSED                                                                                                                                              [ 33%]
tests/test_samples.py::test_samples[multiple_inheritance] PASSED                                                                                                                                                       [ 35%]
tests/test_samples.py::test_samples[interface_unknown_inherit] PASSED                                                                                                                                                  [ 38%]
tests/test_samples.py::test_samples[interface_annotated_attribute] PASSED                                                                                                                                              [ 40%]
tests/test_samples.py::test_samples[forwardref] PASSED                                                                                                                                                                 [ 42%]
tests/test_samples.py::test_samples[classimplements_broken_impl] PASSED                                                                                                                                                [ 45%]
tests/test_samples.py::test_samples[interface_fieldproperty] PASSED                                                                                                                                                    [ 47%]
tests/test_samples.py::test_samples[simple_valid] PASSED                                                                                                                                                               [ 50%]
tests/test_samples.py::test_samples[unknown_metaclass] PASSED                                                                                                                                                          [ 52%]
tests/test_samples.py::test_samples[interface_unknown] PASSED                                                                                                                                                          [ 54%]
tests/test_samples.py::test_samples[interface_implications] PASSED                                                                                                                                                     [ 57%]
tests/test_samples.py::test_samples[schema_unknown_field] PASSED                                                                                                                                                       [ 59%]
tests/test_samples.py::test_samples[classimplements_wrong] PASSED                                                                                                                                                      [ 61%]
tests/test_samples.py::test_samples[interface_unknown_direct] PASSED                                                                                                                                                   [ 64%]
tests/test_samples.py::test_samples[interface_attribute] PASSED                                                                                                                                                        [ 66%]
tests/test_samples.py::test_samples[interface_meta] PASSED                                                                                                                                                             [ 69%]
tests/test_samples.py::test_samples[no_arg_method] PASSED                                                                                                                                                              [ 71%]
tests/test_samples.py::test_samples[interface_mapping] PASSED                                                                                                                                                          [ 73%]
tests/test_samples.py::test_samples[open] PASSED                                                                                                                                                                       [ 76%]
tests/test_samples.py::test_samples[unknown_interface] PASSED                                                                                                                                                          [ 78%]
tests/test_samples.py::test_samples[interface_inheritance] PASSED                                                                                                                                                      [ 80%]
tests/test_samples.py::test_samples[overload] PASSED                                                                                                                                                                   [ 83%]
tests/test_samples.py::test_samples[interface_metaclass] PASSED                                                                                                                                                        [ 85%]
tests/test_samples.py::test_samples[parameterized_types] PASSED                                                                                                                                                        [ 88%]
tests/test_samples.py::test_samples[adaptation] PASSED                                                                                                                                                                 [ 90%]
tests/test_samples.py::test_samples[interface_self] PASSED                                                                                                                                                             [ 92%]
tests/test_samples.py::test_samples[not_fully_implemented] PASSED                                                                                                                                                      [ 95%]
tests/test_samples.py::test_samples[multiple_implementer] PASSED                                                                                                                                                       [ 97%]
tests/test_samples.py::test_samples[schema_text] PASSED                                                                                                                                                                [100%]

---------------------------------------------------------------- generated xml file: ./mypy-zope-fork/var/test-results/results.xml ----------------------------------------------------------------

---------- coverage: platform darwin, python 3.11.5-final-0 ----------
Name                        Stmts   Miss  Cover
-----------------------------------------------
src/mypy_zope/__init__.py       1      0   100%
src/mypy_zope/plugin.py       342     15    96%
-----------------------------------------------
TOTAL                         343     15    96%

==================================================================================================== 42 passed in 32.16s =====================================================================================================
kedder commented 4 months ago

Thank you!

kedder commented 4 months ago

mypy_zope-1.0.5 is released.