Closed DMRobertson closed 1 year ago
Take it out of WIP whenever you're ready to merge this.
I've just done so. (I wanted to run this PR + mypy 1.0 against https://github.com/matrix-org/synapse/. There weren't any new errors related to the plugin AFACIS, other than those covered by #88.)
And thanks for digging into it!
My pleasure. I just hope the hack doesn't come back to bite us in the future!
I just hope the hack doesn't come back to bite us in the future!
I'm sure it will eventually, but we'll deal with it when it happens :)
Released in mypy-zope-0.9.0
For your consideration: an attempt to update this plugin to work with the recent mypy 1.0.0 release.
https://github.com/Shoobx/mypy-zope/pull/85 was an attempt to establish compatibility with mypy 0.991. It was partially successful, but ultimately blocked on https://github.com/python/mypy/issues/14106
I wanted to take a look to see if could make any progress. I think I was able to workaround the linked mypy issue with a dirty, brittle and naughty hack (see https://github.com/Shoobx/mypy-zope/pull/89/commits/da1d0fb4ef97f1d574cf0b458297def76c45ef5c). It might be too brittle to include upstream; let me know what you think.
On my machine, all but one test passes. I am not sure how to handle the failure:
Fixes #82 (I think?) Closes #85