search

Shoobx / mypy-zope

Plugin for mypy to support zope.interface
MIT License
39 stars 13 forks source link

Follow semantic versioning in mypy version pins #96

Closed Daverball closed 1 year ago

Daverball commented 1 year ago

I think until mypy reached 1.0.0 it was a fine policy to pin to the mypy version that was released at the time, since the plugin system is not guaranteed to be stable and the version numbering was sort of semantic, but not really, since it used number digits rather, than numbers separated by dots.

But now that mypy is following semantic versioning rules I think you should consider only pinning the mypy version to before the next minor version, so if the current version was 1.0.0, you would pin to <1.1.0, rather than ==1.0.0, so patch releases, like 1.0.1, which will often contain important bug fixes can still be installed without having to force ignore the version pin.

kedder commented 1 year ago

I agree. Let's try that. I'll update the pin and make a release.

Daverball commented 1 year ago

I realize I didn't state it explicitly, but it probably still makes sense to pin the minimum version too, so people get at least the mypy version the release was tested with, but possibly a newer patch version, when available, i.e. for a release that was tested against 1.0.0 the requirement would be >= 1.0.0, <1.1.0

kedder commented 1 year ago

Yeah, that's exactly what I'm planning to do.

kedder commented 1 year ago

mypy-zope-0.9.1 is released!