I've found that get_page_props() and just the whole page props for data retrieval in general is not a super reliable way of getting the information we need. At best, it provides a full list of seasons, but realistically, this isn't super critical information.
Having this cached and relying solely on page_props() doesnt really make much sense, because if you're ever looking for season information for any given player, that will be returned via the search method.
I initially thought that by using page_props, it would help in cutting down the scrape requests to opgg for batched requests (more than 1 summoner), but inspection of the network requests reveals that the summary endpoint is still called 5 separate times, so any gains there are meaningless.
Thus, I will leave get_page_props() and the cacher functions for get all seasons in, but will be moving away from using get_page_props() in favor of the specific internal endpoints opgg already has. This includes a bit of a refactor in how page_props() is implemented everywhere else in the wrapper.
I've found that get_page_props() and just the whole page props for data retrieval in general is not a super reliable way of getting the information we need. At best, it provides a full list of seasons, but realistically, this isn't super critical information.
Having this cached and relying solely on page_props() doesnt really make much sense, because if you're ever looking for season information for any given player, that will be returned via the search method.
I initially thought that by using page_props, it would help in cutting down the scrape requests to opgg for batched requests (more than 1 summoner), but inspection of the network requests reveals that the summary endpoint is still called 5 separate times, so any gains there are meaningless.
Thus, I will leave get_page_props() and the cacher functions for get all seasons in, but will be moving away from using get_page_props() in favor of the specific internal endpoints opgg already has. This includes a bit of a refactor in how page_props() is implemented everywhere else in the wrapper.