ShoobyDoo / OPGG.py

An unofficial Python library for accessing OPGG data.
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Add better tests for each defined object #14

Closed ShoobyDoo closed 2 months ago

ShoobyDoo commented 2 months ago

Since update 1.2.0, there was a relatively big update from opgg's end that changed the return structure of the data used by opgg.py to build objects. The change ended up breaking some object creation, and thus led to many fields not being populated correctly on the summoner object.

This was hotfixed in 1.3.0, but to identify these issues quicker, some better tests need to be written to verify what's being returned from opgg's site data and api endpoints, and what the differences are between that data and the existing objects.

This could be having a single modular test method that could accept multiple object types and their cooresponding data set. This could then be tested against each objects property and the properties in the data set to identify differences quickly.