search

ShoobyDoo / OPGG.py

An unofficial Python library for accessing OPGG data.
BSD 3-Clause "New" or "Revised" License
13 stars 5 forks source link

Skip null ranked data #39

Closed Edan52 closed 3 months ago

Edan52 commented 3 months ago

This issue occurs when someone has a rank for one ranked type but not the other (for example, I was ranked in solo/duo for a split, but didn't play flex), and so the dictionary has no values to extract. This error prevents the rest of the data being collected for the summoner.

ShoobyDoo commented 3 months ago

This looks good to me. In addition, I will also need to see any other keys that have this same behavior of preventing the rest of the summoner object from being populated and continue past them as well to prevent this kind of issue in the future.

ShoobyDoo commented 3 months ago

This will be included in a small hotfix release 1.4.1