Shoonya-Dev / ShoonyaApi-py

141 stars 133 forks source link

websocket connection opening 2 threads in version 28 #170

Open ENGINEERDK opened 2 months ago

ENGINEERDK commented 2 months ago

Using NorenRestAPI version 28 through wheel.

while opening the WebSocket connection, I can see 2 threads are being launched by the library 'Thread-4 (__ws_run_forever)', 'Thread-5 (_send_ping)'

Thread __ws_run_forever is alright, but _send_ping seems to be stale thread used in development and shipped in production.

I tried to check the library code from kambala tech, they had released new version 29, where no such thread is present only __ws_run_forever.

Can someone confirm if v28 is really generating stale thread unnecessarily?