search

ShootMe / CelesteTAS

Simple TAS tools for the game Celeste
79 stars 14 forks source link

Fix: Having multiple breakpoints would only break on the last one #16

Closed CMDRNuffin closed 5 years ago

CMDRNuffin commented 5 years ago

This is because the break (aka "go to frame step mode") condition would only actually break if no later breakpoints were available.

As an aside: While the project file change doesn't technically belong to the change, it doesn't do anything if you don't have a "deploy.bat" file lying around in the project directory, so I decided to keep it in. Maybe someone finds it useful in the future.

ShootMe commented 5 years ago

This is intentional in the TAS code. Was originally done this way for 6A to get around the desyncs, but beyond that would allow for changing gamespeed on the fly and only break on the final one instead of having it break and then you hit continue over and over with tons of game speed changes. I won't merge this, but Ill leave it out if anyone needs this specifically.

CMDRNuffin commented 5 years ago

I updated the PR to restore the original behavior, while adding ***! as a forced breakpoint, which uses my implementation. That way we can have both speed changes for desync prevention (or skipping over boring parts in presentations) and breaks for presentation purposes/analysing what exactly happens somewhere in another person's TAS :-)