ShootMe / FallGuysStats

Fall Guys Stats Tracker
MIT License
263 stars 56 forks source link

Can't update from v1.137 or older to v1.138/139 #196

Closed iku55 closed 1 year ago

iku55 commented 1 year ago

Unable to update with 404 Not Found error when trying to update from version 1.137 or older. This is because FallGuyStats.zip was changed to FallGuysStats.zip when updating to v1.138. (b20c2c3dd345cd07365697d72f1833347c1171e4 / bb69296788465f37e94b2dd6a8be1ea3ff93634c) Would you like to upload FallGuyStats.zip for this issue?

P.S. I'm making a feature that releases updates automatically. What do you think about using releases for updates?

Micdu70 commented 1 year ago

Even if the zip file is renamed, the updating process will not work correctly because it only extract and replace existing files (so "LiteDB.dll" and "FallGuysStats.exe" in previous versions)... MetroFramework's DLL files will be missing and so the updated program will not launch. :(

EDIT: To be simple, it was a bug in the updating process..., this simple change fixes the issue => https://github.com/Micdu70/FallGuysStats/commit/c029fc2757ea716a1c1546d1da5875c7cc6a13ac

qutrits commented 1 year ago

Since it set the dll file to be embedded in the exe, it probably won't be a problem for this part anymore.

iku55 commented 1 year ago

@qutrits I have a suggestion. Wouldn't you like to use the release for updates? GitHub Docs: Releasing projects on GitHub

When using releases the latest version of the files can be obtained at https://github.com/ShootMe/FallGuysStats/releases/latest/download/[filename].zip Also you can check the latest version using API ( https://api.github.com/repos/ShootMe/FallGuysStats/releases/latest )

qutrits commented 1 year ago

Unfortunately, I don't have release permissions. I hope @ShootMe sees this and gives me permission.

I'm going to spend some time reviewing and applying PRs.

ShootMe commented 1 year ago

You should have all permissions to the repo as far as I can see. Navigate to this link and see if it allows you to do anything https://github.com/ShootMe/FallGuysStats/releases

qutrits commented 1 year ago

@ShootMe I see that I can create a release, thank you.