search

Shopify / FunctionalTableData

Declarative UITableViewDataSource implementation
MIT License
365 stars 30 forks source link

Add separator style inset on both sides #157

Closed abecevello closed 5 years ago

abecevello commented 5 years ago

We have a new design for separators that are inset on both sides (so they appear in the centre). This adds a new style to Separator called bothInset (naming suggestions very welcome!) that anchors the separator to the layout margins on both sides.

Technically adding a new enum value is a breaking change since it would require anyone that uses it in a switch statement without a default to add the new case, but I feel like most people aren't checking this enum in a switch statement outside of FTD.

abecevello commented 5 years ago

Hold off on reviewing this. I'm going to need to make this more configurable.

abecevello commented 5 years ago

This has been updated to allow specifying a custom separator inset. This will allow for more configurability and allow for the full range of new designs we have.