search

Shopify / FunctionalTableData

Declarative UITableViewDataSource implementation
MIT License
365 stars 30 forks source link

Revisit new CellAction previewingViewControllerAction process #168

Closed robinsenior closed 5 years ago

robinsenior commented 5 years ago

The initializer for CellAction now takes a PreviewingViewControllerAction closure for the previewingViewControllerAction argument. Implementors of this closure are expected to call previewingContext.sourceRect = previewingContext.sourceView.convert(cell.bounds, from: cell).

Since I imagine the majority of use cases for PreviewingViewControllerAction will behave the same way, it would be nice if we could have the nominal path for this do the sourceRect assignment automatically.

ghost commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 3 days if no further activity occurs.