Improve diff performances with an early return for empty cases

Shopify / FunctionalTableData

Declarative UITableViewDataSource implementation

MIT License

365 stars 30 forks source link

Improve diff performances with an early return for empty cases #177

Closed TheoBdev closed 5 years ago

TheoBdev commented 5 years ago

By avoiding to run the diff algorithm in full in case of old and/or new sections empty, we gained a few milliseconds in the ChangeSet calculateChanges function.

The performances tests have also been moved to a separate file.

TheoBdev commented 5 years ago

@Caiopia Recorded on my mac with time in seconds:

testPerformanceByMovingRows 0.283 to 0.283
testPerformanceByAddingRows 0.02 to 0.003
testPerformanceByDeletingRows 0.024 to 0.003
testPerformanceByKeepingRows 0.204 to 0.204