Shopify / Timber

The ultimate Shopify theme framework, built by Shopify.
MIT License
1.07k stars 490 forks source link

Adherence to theme requirements #524

Open sheedy opened 8 years ago

sheedy commented 8 years ago

Does this theme meet all of the requirements for a theme to be accepted, as outlined below?

suture commented 8 years ago

No not all, but it will set you in the right direction. To give some quick examples.

It doesn't include a Password template. Also the admin "Customizer' section is very minimal as you would expect with a starter theme.

cshold commented 8 years ago

Happy to review any PRs that you want to open to fill the gaps. The content guide and other theme requirements were updated not too long ago so haven't been updated here, and are not on our roadmap to update as Slate will be taking Timber's place as our recommended starter kit for building themes.

suture commented 8 years ago

Is there a link to slate?

cshold commented 8 years ago

Not just yet, we're still working on a few things and don't have a launch date set.

danielwilber commented 7 years ago

@suture @cshold hey guys, any update on Slate?

walidmahade commented 7 years ago

@suture @cshold hey guys, any update on Slate? Everything on shopify is getting old.

suture commented 7 years ago

Not sure if this is related

https://www.npmjs.com/package/@shopify/slate

suture commented 7 years ago

https://shopify.github.io/slate/

henrymilleruk commented 7 years ago

When was Slate officially launched ??

On 10 March 2017 at 14:05, Ricky Cox notifications@github.com wrote:

https://shopify.github.io/slate/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Shopify/Timber/issues/524#issuecomment-285676834, or mute the thread https://github.com/notifications/unsubscribe-auth/ALG1p6eRoPeUdakcTdJKqTVsloqh03_5ks5rkViogaJpZM4H53nS .

MatthewKennedy commented 7 years ago

If anyone is interested I have a drop in Flexbox Grid replacement for the default Slate CSS Grid. https://github.com/MatthewKennedy/Flexbox-grid-replacment-for-Shopify-Slate

Nothing wrong with the default CSS Grid that comes with the Shopify Slate npm theme, but with the Flexbox Grid you get some of the bonus Flexbox usability baked into the grid.

Matthew Kennedy

Matthew Kennedy

On 10 Mar 2017, at 14:15, henrymilleruk notifications@github.com wrote:

When was Slate officially launched ??

On 10 March 2017 at 14:05, Ricky Cox notifications@github.com wrote:

https://shopify.github.io/slate/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Shopify/Timber/issues/524#issuecomment-285676834, or mute the thread https://github.com/notifications/unsubscribe-auth/ALG1p6eRoPeUdakcTdJKqTVsloqh03_5ks5rkViogaJpZM4H53nS .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

NathanPJF commented 7 years ago

Regarding Slate: