search

Shopify / Timber

The ultimate Shopify theme framework, built by Shopify.
MIT License
1.08k stars 491 forks source link

admin_bar_iframe #568

Open Joe028 opened 8 years ago

Joe028 commented 8 years ago

Many apps look for the admin_bar_iframe in order to determine if the shop owner is logged in or not. It appears that this framework removes this frame by adding in something in it's place. I see this occur in assets/timber.js.liquid

line 281: var $iframeReset = $iframeVideo.add('iframe#admin_bar_iframe');

Could a solution be implemented so that the admin_bar_iframe is not removed?

3stacks commented 8 years ago

It seems to me that there should be a isUserLoggedIn method on the Shopify class so that people can check if admin is logged in without having to rely on a pretty hacky method. Probably an issue for the core Shopify repo imo.