search

Shopify / active_shipping

ActiveShipping is a simple shipping abstraction library extracted from Shopify
http://shopify.github.io/active_shipping
MIT License
812 stars 547 forks source link

Extract or handle FedEx namespaced XML better #139

Open csaunders opened 10 years ago

csaunders commented 10 years ago

Currently we are performing a gsub on all instances of the SOAP APIs version prefix. With the API change that happened on January 19, 2014 this resulted in creating invalid XML that caused a massive breakage.

An example of the invalidly subbed XML can be seen here.

Solution: The gsub is super aggressive and it would probably be better to just properly handle the namespace. Maybe having some 'version detection' to determine which namespace to use could be useful for reverse-compatibility reasons or something.

rdaniels commented 10 years ago

I'm having the same issue. With active_shipping (0.11.2) when i run the code directly it returns FedEx quotes, but when i run it from RSpec 3.0.0.beta1 test I get #<REXML::ParseException: #<NoMethodError: undefined method `[]' for nil:NilClass>