Shopify / active_shipping

ActiveShipping is a simple shipping abstraction library extracted from Shopify
http://shopify.github.io/active_shipping
MIT License
813 stars 547 forks source link

Upgrade to FedEx V18 rate WSDL - UK no service type issues #307

Open trishume opened 9 years ago

trishume commented 9 years ago

According to FedEx the solution to the issues Shopify has been having with some requests within the UK receive rates but no service types is to upgrade to the "V18 rate WSDL".

The reason is that the service types that would be returned in these requests aren't valid for the older version, so instead they make the response totally invalid by not including a crucial field :neutral_face:

@kmcphillips cc @eboswort in case Casper has also noticed this issue

kmcphillips commented 9 years ago

We aren't using the WSDL at all.

trishume commented 9 years ago

The most recent docs on the FedEx site are for V16 :crying_cat_face:

eboswort commented 9 years ago

Hmm, we actually haven't been shipping via Fedex lately at all, so I haven't run into any trouble. Looks like we're using version 13 of the API?

Do we just change this line: https://github.com/Shopify/active_shipping/blob/master/lib/active_shipping/carriers/fedex.rb#L290 to say 18 and then see what breaks?

kmcphillips commented 9 years ago

It's possible that the XML API does support newer versions without the WSDL, and it's just not published anymore.