search

Shopify / active_shipping

ActiveShipping is a simple shipping abstraction library extracted from Shopify
http://shopify.github.io/active_shipping
MIT License
813 stars 547 forks source link

Catch ActiveUtils::ResponseError during CanadaPostPWS receipt request #516

Closed bibstha closed 7 years ago

bibstha commented 7 years ago

Right now we do not trap the ActiveUtils::ResponseError here. We should trap this and return an ActiveShipping::ResponseError instead.

anthonyn60 commented 7 years ago

This one is a little tricky just because parse_shipment_receipt_response doesn't return a CPPWS response but rather a simple Hash so we can't use error_response like the other rescue statements.