search

Shopify / android-testify

Add screenshots to your Android tests
https://testify.dev
MIT License
231 stars 23 forks source link

Replace deprecated maven plugin with maven-publish #229

Closed jaredh closed 3 years ago

jaredh commented 3 years ago

What does this change accomplish?

Part of supporting Gradle 7.0.

Removes the deprecated maven plugin, replacing it with maven-publish to handle our Maven publishing tasks.

Added ability to run publishToMavenLocal and skip signing if you don't have the environment variables set.

Tophat instructions

  1. Publish Plugin and Library to your local maven repository ./gradlew Library:publishToMavenLocal Plugin:publishToMavenLocal

  2. Validate that the packages being generated contain expected POM information and artifacts Local Plugin: ~/.m2/repository/com/shopify/testify/plugin/1.1.0-beta2 Published Plugin: https://repo1.maven.org/maven2/com/shopify/testify/plugin/1.1.0-beta2/

    Local Library: ~/.m2/repository/com/shopify/testify/testify/1.1.0-beta2 Published Library: https://repo1.maven.org/maven2/com/shopify/testify/testify/1.1.0-beta2/

jaredh commented 3 years ago

I amended this PR to include 2036b565bc1f8b6f458c229b74539a74ee934b89 so that the GitHub action actually runs publish. 😇