search

Shopify / android-testify

Add screenshots to your Android tests
https://testify.dev
MIT License
231 stars 23 forks source link

Migrate to Dokka 1.4.32 for Gradle 7 support #230

Closed jaredh closed 3 years ago

jaredh commented 3 years ago

What does this change accomplish?

Part of supporting Gradle 7.0

Upgrade Dokka to 1.4.32 which resolves some deprecated functionality used in old version.

How have you achieved it?

Following doks at https://github.com/Kotlin/dokka/blob/master/runners/gradle-plugin/MIGRATION.md.

Tophat instructions

  1. Can publish to local repository and check if documentation works as expected
jaredh commented 3 years ago

Daemon will be stopped at the end of the build after running out of JVM memory

@DanielJette Reading through https://github.com/Kotlin/dokka/issues/1405 it might be using an existing Gradle daemon that's configured with lower memory settings than Dokka requires. Can you try some of the suggestions there? Specifically the --no-daemon option. I can't reproduce this OOM locally but I'm very generous to my JVMs. 😅

DanielJette commented 3 years ago

Daemon will be stopped at the end of the build after running out of JVM memory

@DanielJette Reading through Kotlin/dokka#1405 it might be using an existing Gradle daemon that's configured with lower memory settings than Dokka requires. Can you try some of the suggestions there? Specifically the --no-daemon option. I can't reproduce this OOM locally but I'm very generous to my JVMs. 😅

@jaredh I'll give it a try right now. I assume it's using whatever I have in local.properties for the JVM/gradle settings, but I probably have nothing set ... so whatever the defaults are 🤷

jaredh commented 3 years ago

Ran some smoke tests on the GitHub publishing pipeline to see if actions infra had any memory issues. Looks all good!

https://github.com/Shopify/android-testify/runs/3196038651?check_suite_focus=true