Closed jaredh closed 3 years ago
When rootViewId was made protected it inadvertently broke interop with Java subclasses due to the conflicting method signatures of the generated setter and this function https://github.com/Shopify/android-testify/blob/1ad32a9f5777f07768773c536a36ed76fdbdfb64/Library/src/main/java/com/shopify/testify/ScreenshotRule.kt#L218
rootViewId
This fix renames the setter for Java classes while Kotlin property accessors remain unchanged.
JvmName
setRootViewIdResource
1.1.0-beta2
ScreenshotRule
What does this change accomplish?
When
rootViewId
was made protected it inadvertently broke interop with Java subclasses due to the conflicting method signatures of the generated setter and this function https://github.com/Shopify/android-testify/blob/1ad32a9f5777f07768773c536a36ed76fdbdfb64/Library/src/main/java/com/shopify/testify/ScreenshotRule.kt#L218This fix renames the setter for Java classes while Kotlin property accessors remain unchanged.
How have you achieved it?
JvmName
annotation and rename the Java setter tosetRootViewIdResource
Tophat instructions
1.1.0-beta2
Create a class that extendsScreenshotRule
in Java and it will fail to compile due to conflicting method signatures.