Using the Travis build matrix, this runs the tests using 3 versions of bundler and 4 versions of Ruby. The reason I think this would be a nice addition is because bootboot uses several unstable/private APIs, including reading instance variables like definition.instance_variable_get(:@unlock). Running the test suite on many versions of bundler would reduce the risk of a Bundler change breaking bootboot.
I'm not sure if this addition is welcome since it could increase the runtime of the test suite on CI. Supposedly there is a limit of 200 concurrent jobs, but it looks like Travis will only run about 5 jobs in parallel, but maybe I have something misconfigured.
Maybe running on many Ruby versions is not as valuable as running on many Bundler versions, so if you like the idea but not the number of jobs, it'd be easy to run all the versions of bundler but only one version of Ruby.
rafaelfranca
commented
4 years ago
Using the Travis build matrix, this runs the tests using 3 versions of bundler and 4 versions of Ruby. The reason I think this would be a nice addition is because bootboot uses several unstable/private APIs, including reading instance variables like
definition.instance_variable_get(:@unlock). Running the test suite on many versions of bundler would reduce the risk of a Bundler change breaking bootboot.I'm not sure if this addition is welcome since it could increase the runtime of the test suite on CI. Supposedly there is a limit of 200 concurrent jobs, but it looks like Travis will only run about 5 jobs in parallel, but maybe I have something misconfigured.
Maybe running on many Ruby versions is not as valuable as running on many Bundler versions, so if you like the idea but not the number of jobs, it'd be easy to run all the versions of bundler but only one version of Ruby.