search

Shopify / bootboot

Dualboot your Ruby app made easy
MIT License
416 stars 35 forks source link

Stop using `Bundler::RubyVersion#to_gem_version_with_patchlevel` #41

Closed deivid-rodriguez closed 2 years ago

deivid-rodriguez commented 2 years ago

This method reports the patch level of Ruby, which is no longer useful since Ruby 2.0.0, and was causing Bundler to show some strange error messages about Ruby version with 4 segments, like 3.1.1.0.

The method was removed too aggressively from Bundler without knowing that it was actually being used by bootboot. Depending on how widely it's actually used, we might restore it with a deprecation, but this commit makes bootboot use a better method.

Fixes #40.

tjchambers commented 2 years ago

This looks like a winner to me. thx @deivid-rodriguez

deivid-rodriguez commented 2 years ago

That was fast, thanks so much @nvasilevski!