Shopify / bootboot

Dualboot your Ruby app made easy
MIT License
416 stars 35 forks source link

Centralize Ruby Version to `.ruby-version` #66

Closed jenshenny closed 3 months ago

jenshenny commented 3 months ago

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

[!IMPORTANT] Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

jenshenny commented 3 months ago

Hmm CI is failing on pull_request but not on push... going need to take a closer look at this.

jenshenny commented 3 months ago

I think it's from updating bundler https://github.com/Shopify/bootboot/pull/64#issuecomment-1805554376