Prevent destroying presented views if preload is called after present - Githubissues

Shopify / checkout-sheet-kit-android

Shopify’s Checkout Sheet Kit makes it simple to perform a checkout inside your Android app.

MIT License

12 stars 3 forks source link

Prevent destroying presented views if preload is called after present #104

Closed kiftio closed 6 months ago

kiftio commented 6 months ago

What are you trying to accomplish?

When preload is called, we destroy old views and add new ones to the cache to avoid memory leaks.
If the old view is in the view hierarchy, we may destroy it while it is visible. This PR aims to avoid that, but loading the submitted URL in the existing view if it's visible.

Before you deploy

[x] I have added tests to support my implementation
[x] I have read and agree with the contributing documentation
[x] I have read and agree with the code of conduct documentation
[ ] I have updated the README (if applicable).