search

Shopify / checkout-sheet-kit-android

Shopify’s Checkout Sheet Kit makes it simple to perform a checkout inside your Android app.
MIT License
12 stars 3 forks source link

Unable to upload anything when clicking Upload ID button on Tamara #115

Closed AsimNGI closed 1 month ago

AsimNGI commented 3 months ago

What area is the issue related to?

Checkout Sheet Kit

What version of the package are you using?

3.0.2

Reproducible sample code

No response

Steps to Reproduce

  1. Open checkout
  2. Select option with any installment plan, in my case it's Tamara.
  3. Click on Pay now.
  4. Otp Verification
  5. It will ask to Upload ID of front & back but button is not doing anything.

Expected Behavior

There can be two ideal cases:

  1. If Camera permission is not given it should ask for Camera permission and then opens camera to capture picture.
  2. If camera permission is given, it should directly opens camera.

Actual Behavior

By clicking on Upload ID nothing happened.

Screenshots/Videos/Log output

https://github.com/user-attachments/assets/e2e0f904-5029-46f7-a497-d2d6aab8ada8

Storefront domain

https://revibe.me/

kiftio commented 3 months ago

Did you already do something like this:

https://github.com/Shopify/checkout-sheet-kit-android/blob/6cb7598c8a5e7facbdb4a7e5ad6233293ae99b69/samples/MobileBuyIntegration/app/src/main/java/com/shopify/checkout_sdk_mobile_buy_integration_sample/common/MobileBuyEventProcessor.kt#L85

And add the relevant permissions to your AndroidManifest?

AsimNGI commented 3 months ago

Yup, already gave permission for the microphone and camera. I've also attached the screenshot of app permissions.

On Mon, Jul 29, 2024 at 7:27 PM Dan Kift @.***> wrote:

Did you already do something like this:

https://github.com/Shopify/checkout-sheet-kit-android/blob/6cb7598c8a5e7facbdb4a7e5ad6233293ae99b69/samples/MobileBuyIntegration/app/src/main/java/com/shopify/checkout_sdk_mobile_buy_integration_sample/common/MobileBuyEventProcessor.kt#L85

And add the relevant permissions to your AndroidManifest?

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2256095854, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOWAZ63UPH5EUU3OHETZOZGOFAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGA4TKOBVGQ . You are receiving this because you authored the thread.Message ID: @.***>

kiftio commented 3 months ago

So you've called something like ActivityCompat.requestPermissions(), and then clicked something like allow this time as a user r.e. camera and microphone? And the button still doesn't work?

Is that the same if you close and reopen checkout and retry (i.e. when permissions have been granted before opening checkout)?

AsimNGI commented 3 months ago

Yes, tried this solution already but still got the same issue.

On Tue, Jul 30, 2024 at 1:18 PM Dan Kift @.***> wrote:

So you've called something like ActivityCompat.requestPermissions(), and then clicked something like allow this time as a user r.e. camera and microphone? And the button still doesn't work?

Is that the same if you close and reopen checkout and retry (i.e. when permissions have been granted before opening checkout)?

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2257754972, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOS4W4C4HOG3SI2PBQLZO5D6PAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXG42TIOJXGI . You are receiving this because you authored the thread.Message ID: @.***>

kiftio commented 3 months ago

In that case I think we'll have to setup a store in the right region, install Tamara, request an API key, etc. to debug.

It might take a little while. I'll update when there's more info

AsimNGI commented 3 months ago

Thank you Dan for looking into this.However, can you please mention how much time will it take to debug this issue ? We are losing 20% of our customers due to this.

On Tue, Jul 30, 2024 at 2:41 PM Dan Kift @.***> wrote:

In that case I think we'll have to setup a store in the right region, install Tamara, request an API key, etc. to debug.

It might take a little while. I'll update when there's more info

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2257925596, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOUOXCK3F2IZ3V4ZXCTZO5NVDAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXHEZDKNJZGY . You are receiving this because you authored the thread.Message ID: @.***>

AsimNGI commented 3 months ago

We can provide the keys or any support required from Tamara to expedite the process.

On Wed, Jul 31, 2024 at 10:35 AM Syed Asim Zubair @.***> wrote:

Thank you Dan for looking into this.However, can you please mention how much time will it take to debug this issue ? We are losing 20% of our customers due to this.

On Tue, Jul 30, 2024 at 2:41 PM Dan Kift @.***> wrote:

In that case I think we'll have to setup a store in the right region, install Tamara, request an API key, etc. to debug.

It might take a little while. I'll update when there's more info

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2257925596, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOUOXCK3F2IZ3V4ZXCTZO5NVDAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXHEZDKNJZGY . You are receiving this because you authored the thread.Message ID: @.***>

AsimNGI commented 3 months ago

@kiftio can you please give us any update regarding the issue ?

kiftio commented 3 months ago

Hi @AsimNGI Tamara said that you'd need to reach out to them and provide ID for them to be able for them to help.

I'm going to try testing against your store

kiftio commented 3 months ago

Ah unfortunately, the first step is to verify a mobile number, which must be a UAE number. So, I'm still a bit stuck I'm afraid

Does anything show up in the logs when you go through the flow?

AsimNGI commented 3 months ago

Any update?

On Wed, Jul 31, 2024 at 4:03 PM Ali Hanif @.***> wrote:

We can provide the keys or any support required from Tamara to expedite the process.

On Wed, Jul 31, 2024 at 10:35 AM Syed Asim Zubair < @.***> wrote:

Thank you Dan for looking into this.However, can you please mention how much time will it take to debug this issue ? We are losing 20% of our customers due to this.

On Tue, Jul 30, 2024 at 2:41 PM Dan Kift @.***> wrote:

In that case I think we'll have to setup a store in the right region, install Tamara, request an API key, etc. to debug.

It might take a little while. I'll update when there's more info

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2257925596, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOUOXCK3F2IZ3V4ZXCTZO5NVDAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJXHEZDKNJZGY . You are receiving this because you authored the thread.Message ID: @.***>

kiftio commented 3 months ago

I can't test Tamara without a UAE number unfortunately. So no, no update.

Can you see if there are any logs when the page is loaded / button clicked?

AsimNGI commented 3 months ago

@kiftio The logs are not showing anything when clicking on button. Can we align a meeting? So we can do testing on UAE number ?

AsimNGI commented 3 months ago

@kiftio Waiting for your response to expedite the process.

allyshiasewdat commented 3 months ago

Hi @AsimNGI - This is important to us, and we will have the bandwidth to investigate this further at the end of August at the earliest.

In the meanwhile, were you able to test whether this works in a standard web view, without the Checkout Sheet Kit?

AsimNGI commented 3 months ago

Yes it is working fine without checkout sheet kit, I've tested this on our store and it opens camera for ID verification.

On Sat, 10 Aug 2024, 12:18 am Allyshia Sewdat, @.***> wrote:

Hi @AsimNGI https://github.com/AsimNGI - This is important to us, and we will have the bandwidth to investigate this further at the end of August at the earliest.

In the meanwhile, were you able to test whether this works in a standard web view, without the Checkout Sheet Kit?

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2278592613, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOXS6WYRE476MYU63WDZQUIW3AVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGU4TENRRGM . You are receiving this because you were mentioned.Message ID: @.***>

kiftio commented 3 months ago

@AsimNGI Few more questions to help us double check things:

Thanks

AsimNGI commented 3 months ago

I'm testing in a real device and it's not working in all android models of all brands and tested in all OS versions. Still same issue is coming.

On Sat, 10 Aug 2024, 1:40 pm Dan Kift, @.***> wrote:

@AsimNGI https://github.com/AsimNGI Few more questions to help us double check things:

  • Are you testing via the emulator or on a real device?
  • Which Android OS version are you using?
  • Can you try in a different device (different model, different OS) and report back if you see the same issue?

Thanks

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2280357019, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOQZR275MDPZXFYVL5LZQXGWXAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBQGM2TOMBRHE . You are receiving this because you were mentioned.Message ID: @.***>

AsimNGI commented 3 months ago

@kiftio Any update ? We're loosing 20% of our customers due to this bug. Can we schedule a meeting at your earliest? and we can provide you our UAE number to test

AsimNGI commented 3 months ago

Kindly give any update on this issue! It's been too long, can't wait further to loose more users. Provide any update? on this issue & kindly priorities this issue so it can be closed by the end of August. @kiftio @allyshiasewdat

LouisMVA commented 3 months ago

@AsimNGI - We've been working through your merchant success manager to setup a call so we can debug further. There should have been an email sent to your team last week to coordinate a time to meet. Please follow up there and we'll be happy to provide further guidance.

AsimNGI commented 3 months ago

Hi @LouisMVA! Where have you sent the email. We are unable to find any and can you please keep my email in loop as well?

LouisMVA commented 3 months ago

Mind sharing your email with me? I can make sure you get copied

AsimNGI commented 2 months ago

Sure, my email is asim.zubair@nextgeni.com.

AsimNGI commented 2 months ago

Hi @LouisMVA ! We had multiple connects with @kiftio regarding this issue. However, we are stuck in only 1 edge case which is regarding to the camera. We tested in multiple devices and here are the results: Image Upload:

When we pick an image using the image picker, everything works fine on all devices we've tested so far.

Camera:

  1. Initially, the camera worked fine on two devices: Google Pixel (Android 11) and Samsung (Android 11).

  2. However, when we retested the checkout flow on the same Samsung device, we were unable to place the photo on Tamara's checkout WebView after taking and selecting the picture. (Video 1)

  3. We encountered the same issue (issue - 2) when testing on an Infinix phone (Android 13). (Video 1)

  4. On a Xiaomi phone (Android 14), after taking a picture and selecting the photo, the screen blacked out, and we had to close the app. (No video, happened all of sudden)

  5. We retested on the same Xiaomi device, and after selecting the photo by taking a picture, the checkout flow was dismissed. (Video 2).

https://drive.google.com/file/d/1P6p669D1C7rRuqWtgF9LPxJdnhK13is_/view?usp=drive_link: (Video 1) https://drive.google.com/file/d/1P9whb_ym0AIGKrVyg4Tf9jZniqBA4p_D/view?usp=drive_link: (Video 2)

kiftio commented 1 month ago

It sounds like we're now OK based on https://github.com/Shopify/checkout-sheet-kit-android/pull/130 so I think we can close this ticket

AsimNGI commented 1 month ago

+Muhammad Musharaf @.***>

On Tue, Oct 1, 2024 at 7:09 PM Dan Kift @.***> wrote:

It sounds like we're now OK based on #130 https://github.com/Shopify/checkout-sheet-kit-android/pull/130 so I think we can close this ticket

— Reply to this email directly, view it on GitHub https://github.com/Shopify/checkout-sheet-kit-android/issues/115#issuecomment-2386078274, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKCNJOXCMU5ZNWVPTKXZXRDZZKUITAVCNFSM6AAAAABLUL6EQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWGA3TQMRXGQ . You are receiving this because you were mentioned.Message ID: @.***>