Shopify / checkout-sheet-kit-android

Shopify’s Checkout Sheet Kit makes it simple to perform a checkout inside your Android app.
MIT License
12 stars 3 forks source link

Remove cache invalidation on close of the CheckoutDialog #68

Closed kiftio closed 9 months ago

kiftio commented 9 months ago

What are you trying to accomplish?

Copied description from the swift repo - https://github.com/Shopify/checkout-sheet-kit-swift/pull/97

When you close the checkout sheet, the preloading cache is cleared. This has been raised numerous times as a bug. The core of the issue is we don't not know when the users cart becomes invalid

We need to avoid this pitfall:

The assumption in this PR is, if the merchant calls preload once, they are taking responsibility to call it again when cart updates

Ideally we want the best of both worlds:

Before you deploy