Shopify / checkout-sheet-kit-android

Shopify’s Checkout Sheet Kit makes it simple to perform a checkout inside your Android app.
MIT License
12 stars 3 forks source link

The present function returns the Dialog so it can be dismissed at a later time #93

Closed lorenzOliveto closed 6 months ago

lorenzOliveto commented 6 months ago

What are you trying to accomplish?

Have the possibility to dismiss the CheckoutDialog once the checkout is completed. At the moment this is not possible since we don't have the instance of the dialog created so we can't call dismiss on it. With this PR the CheckoutDialog reference is returned so it can be used later to dismiss it.

Before you deploy

kiftio commented 6 months ago

Hi @lorenzOliveto thanks for the PR. We'll take a look at it early next week

lorenzOliveto commented 6 months ago

Thanks @kiftio for the reivew, to answer your question, I have a Flutter app that invokes that code from a Flutter plugin. That means that I only have the activity and I need a way to close the sheet once the checkout is completed.

I'll make those changes and update the PR.