Shopify / checkout-sheet-kit-android

Shopify’s Checkout Sheet Kit makes it simple to perform a checkout inside your Android app.
MIT License
12 stars 3 forks source link

use default description if reason phrase is blank #96

Closed kiftio closed 6 months ago

kiftio commented 6 months ago

What are you trying to accomplish?

I noticed that the reasonPhrase was empty for a 502 during testing. This adds a default errorDescription for that case.

Also tries to make the tests a little easier to read by adding a custom assertion class, chaining assertions fluently, and extracting a function to trigger the http error callback.

Before you deploy