Shopify / checkout-sheet-kit-react-native

Shopify's Checkout Sheet Kit for React Native - simplifying the process of adding checkout to your native apps.
https://shopify.dev/docs/custom-storefronts/mobile-apps
MIT License
30 stars 3 forks source link

Add expo config plugin to handle Android Webview title #80

Open xseignard opened 4 months ago

xseignard commented 4 months ago

What changes are you making?

Add expo config plugin to be able to change android webview title in a managed expo project.

How to test


PR Checklist

[!IMPORTANT]


Checklist for releasing a new version - [x] I have bumped the version number in the [`package.json` file](https://github.com/Shopify/checkout-sheet-kit-react-native/blob/main/modules/%40shopify/checkout-sheet-kit/package.json#L4). - [x] I have added a [Changelog](./CHANGELOG.md) entry.

[!TIP] See the Contributing documentation for instructions on how to publish a new version of the library.

xseignard commented 4 months ago

I have signed the CLA!

markmur commented 4 months ago

Hey @xseignard, thanks for the PR. We are discussing internally whether we want to explicitly add support for managed workflows in Expo.

👀

markmur commented 4 months ago

@xseignard have you given any thought to how this might work cross-locale?

xseignard commented 4 months ago

Hello @markmur,

Good call, I updated the plugin to handle this

xseignard commented 3 months ago

Any updates here?