search

Shopify / checkout-sheet-kit-swift

Shopify’s Checkout Sheet Kit makes it simple to perform a checkout inside your Swift native app.
MIT License
38 stars 16 forks source link

Make CheckoutWebViewController open or public #185

Closed joshuapoq closed 3 months ago

joshuapoq commented 5 months ago

What area is the issue related to?

Checkout Sheet Kit

What version of Checkout Sheet Kit are you using?

3.0.1

Reproducible sample code

No response

Steps to Reproduce

N/A

Expected Behavior

We want to use our own navigation controller and not use the close button from your controller UI so that we can gain access to your bridge handling but without most of the UI. Anyway to workaround this I've nested your view controller in a container controller to fit with our platform.

Actual Behavior

Currently the initialiser is public but the class is internal.

Screenshots/Videos/Log output

No response

Storefront domain

N/A

joshuapoq commented 5 months ago

This is a feature request but I couldn't mark it as such when creating the issue.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in 30 days. Thank you for your contributions.

github-actions[bot] commented 3 months ago

This issue has been automatically closed because it has not had recent activity. Please re-open it if it is still relevant.