Closed hsdonkin closed 3 weeks ago
I think I've figured out part of it, which is that the debug log is pointing to the wrong theme extension, which was actually deleted previously in a config push. It's actually still in our partner dashboard, and we can't seem to remove it 😞
Related to https://github.com/Shopify/cli/issues/3343 @isaacroldan if you have time to check this issue out!
10:27:52 │ extensions │ DEBUG [HotReload] Modified: blocks/purchase-widget.liquid
10:27:53 │ extensions │ DEBUG POST https://partners.shopify.com/api/cli/graphql with request_id:
0a7d8a64-ff33-4c07-8a33-368a1f57a7ce
10:27:53 │ extensions │ DEBUG {"data"=>{"extensionUpdateDraft"=>{"extensionVersion"=>{"config"=>"{\"theme_exte
nsion\":{\"files\":{\"assets\":{\"app.css\":{\"sha256\":\"mm/qfPVk5qlb95kHs5PHHhY2npluQUQ9UCUyZBCJeYY=\",\"siz
e\":9},\"app.js\":{\"sha256\":\"sqDYRTW0ke7RbJaYwH/uYRIlbkgxVsRzvkthkUF63yA=\",\"size\":19,\"blocks\":{\"purch
ase-widget.liquid\":{\"value\":\"Working working\\n\\n\\u003cfieldset class='selling-plan-fieldset'
data-product='{{ product | json }}'\\u003e\\n \\u003clegend\\u003ePurchase options\\u003c/legend\\u003e\\n
{% unless product.requires_selling_plan %}\\n \\u003cinput type='radio' name='purchase_option'\\u003e
One-time purchase\\n {% endunless %}\\n\\n {% for group in product.selling_plan_groups %}\\n \\u003cinput
type='radio' name='purchase_option'\\u003e {{ group.name }}\\n\\n {% for option in group.options %}\\n
\\u003clabel\\u003e{{ option.name }}\\u003c/label\\u003e\\n\\n \\u003cselect data-position='{{
option.position }}'\\u003e\\n {% for value in option.values %}\\n \\u003coption\\u003e{{ value
}}\\u003c/option\\u003e\\n {% endfor %}\\n \\u003c/select\\u003e\\n {% endfor %}\\n {% endfor
%}\\n\\u003c/fieldset\\u003e\\n\\n{% schema %}\\n{\\n \\\"name\\\": \\\"Renewify Purchase Options\\\",\\n
\\\"target\\\": \\\"section\\\",\\n \\\"enabled_on\\\": {\\n \\\"templates\\\": [\\\"product\\\"]\\n
},\\n \\\"stylesheet\\\": \\\"app.css\\\",\\n \\\"javascript\\\": \\\"app.js\\\",\\n \\\"settings\\\":
[]\\n}\\n{% endschema %}\\n\",\"locales\":{\"en.default.json\":{\"value\":\"{}\\n\"}",
"registrationId"=>"36075798529", "context"=>nil, "lastUserInteractionAt"=>"2024-02-20T13:27:53-05:00",
"location"=>"https://partners.shopify.com/132835/apps/71866449921/extensions/theme_app_extension/36075798529",
"validationErrors"=>[]}, "userErrors"=>nil}
10:27:53 │ extensions │ Pushed » 'purchase-option-widget' to a draft
10:27:53 │ extensions │ - blocks/purchase-widget.liquid
Another weird aspect to this -- I can hot reload assets such as app.js
, for anything .liquid
I need to do an app deployment
I noticed the same issue many times.
Love to get an update on this, we're currently paralyzed trying to develop theme extensions for our app without running multiple deploys per day
This is really confusing, you can dev theme extensions same with pixels as well there is a cache layer I think and that must be removed on dev.
Yeah we're in a really terrible spot where we're running dev
for a theme extension, it's creating a preview theme, but it's pushing updates to a deleted extension. The CLI identifies this extension via the link to the partner dashboard, but it just points at an Unexpected error
page.
09:00:08 │ extensions │ Pushing theme... 24%
09:00:09 │ extensions │ Pushing theme... 32%
09:00:10 │ extensions │ Pushing theme... 41%
09:00:10 │ extensions │ Pushing theme... 53%
09:00:11 │ extensions │ Pushing theme... 62%
09:00:11 │ extensions │ Pushing theme... 70%
09:00:13 │ extensions │ Pushing theme... 83%
09:00:14 │ extensions │ Pushing theme... 91%
09:00:14 │ extensions │ Pushing theme... 100%
09:00:15 │ extensions │ ------------------
09:00:15 │ extensions │
09:00:15 │ extensions │ --------- Viewing extension…
09:00:15 │ extensions │ Enable your theme app extension:
09:00:15 │ extensions │ https://partners.shopify.com/132835/apps/87959109633/extensions/theme_app_extension/60094840833
09:00:15 │ extensions │
09:00:15 │ extensions │ Setup your theme app extension in the host theme:
09:00:15 │ extensions │ https://wlcr-partners.myshopify.com/admin/themes/135135330480/editor
09:00:15 │ extensions │
09:00:15 │ extensions │ Preview your theme app extension:
09:00:15 │ extensions │ http://127.0.0.1:9292
09:00:15 │ extensions │ ------------------
This is the graphql response from the network tab:
{
"data": {
"app": {
"id": "87959109633",
"extensionRegistration": null,
"__typename": "App"
}
}
}
Bumping this if anyone from Shopify is listening, we're still blocked completely on theme extension development for our app. It's a huge bummer!
For some reason when we run shopify app dev
, we get
10:41:58 │ extensions │ --------- Viewing extension…
10:41:58 │ extensions │ Enable your theme app extension:
10:41:58 │ extensions │ https://partners.shopify.com/132835/apps/87959109633/extensions/theme_app_extension/60094840833
10:41:58 │ extensions │
10:41:58 │ extensions │ Setup your theme app extension in the host theme:
10:41:58 │ extensions │ <LINK REDACTED>
10:41:58 │ extensions │
10:41:58 │ extensions │ Preview your theme app extension:
10:41:58 │ extensions │ http://127.0.0.1:9292
10:41:58 │ extensions │ ------------------
This extension link just points at a broken page, probably a deleted extension
Same here !
Same issue. This has completely broken theme app extension development.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
As far as I'm aware, this issue still exists.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
Please confirm that you have:
In which of these areas are you experiencing a problem?
App, Extension, Theme
Expected behavior
When I add a theme extension to my Remix app, and connect my app to a development store, then I should see the example app in the list of app blocks for the product form
Actual behavior
The example rating stars app block doesn't appear in the customizer. Deploying the app makes the app block appear, and it can be added to the development theme, but the app block doesn't show changes in HMR. Deploying the app again makes the changes appear.
Verbose output