search

Shopify / cli

Build apps, themes, and hydrogen storefronts for Shopify
https://shopify.dev
MIT License
416 stars 125 forks source link

[Feature]: dev-server HotReload event #3493

Open eloyesp opened 7 months ago

eloyesp commented 7 months ago

What area(s) will this request affect?

Running your code locally

What type of change do you want to see?

New feature

Overview

There is a script for HotReload that is embedded on the html on the development server: 'theme_extension.js', it would be nice to have a custom refresh event being triggered to make sure that non-idempotent javascript can run again.

Motivation

When themes with many scripts that depend on 'onload' event, hotreload is not great.

github-actions[bot] commented 4 months ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] commented 3 months ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] commented 1 month ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.