[Bug]: app deploy command throw error when passing a self-hosted git URL to --source-control-url

[olidaver]

Please confirm that you have:

• [X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
• [X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

App

Expected behavior

The command

export SHOPIFY_FLAG_SOURCE_CONTROL_URL=https://myselfhosted.gitlab.example/my-app
npm run shopify app deploy -- --force

ran successfully

Actual behavior

Show error: https://myselfhosted.gitlab.example/my-app is not a valid https URL for a git hosting service

Verbose output

shopify app deploy --force
╭─ info ───────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  Using shopify.app.test.toml:                                                │
│                                                                              │
│    • Org:             MY ORG                                                 │
│    • App:             my-app                                                 │
│    • Include config:  Yes                                                    │
│                                                                              │
│   You can pass `--reset` to your command to reset your app configuration.    │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯
Releasing a new app version as part of my-app
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
Running validation ...
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
Releasing an app version ...
╭─ error ──────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  Version couldn't be created.                                                │
│                                                                              │
│  https://myselfhosted.gitlab.example/my-app is not a                         │
│  valid https URL for a git hosting service                                   │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

Reproduction steps

1. npm install
2. setup app client id and configuration file
3. export SHOPIFY_FLAG_SOURCE_CONTROL_URL=https://myselfhosted.gitlab.example/my-app
4. npm run shopify app deploy -- --force

Operating System

Ubuntu 22.04.3 LTS

Shopify CLI version (check your project's package.json if you're not sure)

3.60.1

Shell

bash

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

Node 21-alpine

[amcaplan]

Hi @olidaver, you were totally correct on this. We have loosened the rules around source control URLs. Please let us know whether you are still experiencing this issue.

[olidaver]

Thank you @amcaplan, it's working now.