search

Shopify / cli

Build apps, themes, and hydrogen storefronts for Shopify
https://shopify.dev
MIT License
432 stars 130 forks source link

[Feature]: Theme Asset Upload Priority #4409

Closed ceri-waterscreative closed 1 month ago

ceri-waterscreative commented 2 months ago

What area(s) will this request affect?

Theme

What type of change do you want to see?

New feature

Overview

Currently when running "shopify theme dev" the assets are uploaded in A-Z format, however if you have a lot of images in that folder (i.e. icons) it can take some time to actually upload. Instead I propose changing it to prioritise JS/CSS files first as they're more critical to the site and the developer can continue working while images are uploaded in the background.

Motivation

Impatiently waiting for themes with lots of icons to upload

lucyxiang commented 2 months ago

Hello @ceri-waterscreative, thank you for raising this issue. We have a project in flight that will improve performance of asset uploads, thank you for your patience 🙏

karreiro commented 1 month ago

Thank you for reporting this issue, @ceri-waterscreative!

The new implementation of the shopify theme dev command (in the latest Shopify CLI release) no longer requires the synchronization phase to power the localhost preview and serves JS/CSS directly from the disk. With that in mind, I'm marking this issue as resolved :)