Shopify / cli

Build apps, themes, and hydrogen storefronts for Shopify
https://shopify.dev
MIT License
436 stars 128 forks source link

[dnm] _include directive demo in TOML #4540

Closed shauns closed 1 week ago

github-actions[bot] commented 1 month ago

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

github-actions[bot] commented 1 month ago

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/common/json.d.ts ```diff @@ -1,6 +1,5 @@ export interface JsonMap { [key: string]: AnyJson; } -type JsonArray = undefined[] | null[] | boolean[] | number[] | string[] | JsonMap[] | Date[]; -export type AnyJson = undefined | null | boolean | number | string | JsonMap | Date | JsonArray | JsonArray[]; -export {}; \ No newline at end of file +export type JsonArray = undefined[] | null[] | boolean[] | number[] | string[] | JsonMap[] | Date[]; +export type AnyJson = undefined | null | boolean | number | string | JsonMap | Date | JsonArray | JsonArray[]; \ No newline at end of file ```
packages/cli-kit/dist/public/node/toml.d.ts ```diff @@ -1,5 +1,7 @@ -import { JsonMap } from '../../private/common/json.js'; +import { JsonMap, AnyJson, JsonArray } from '../../private/common/json.js'; export type JsonMapType = JsonMap; +export type AnyJsonType = AnyJson; +export type JsonArrayType = JsonArray; /** * Given a TOML string, it returns a JSON object. * ```
github-actions[bot] commented 2 weeks ago

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.