Open isaacroldan opened 1 day ago
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
Filename | exports |
---|---|
packages/app/src/cli/services/app/write-app-configuration-file.ts | appTomlInitialComment appTomlScopesComment |
We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
main
you might see odd diffs, rebase main
into this branch.We found no new type declarations in this PR
WHY are these changes introduced?
Be more specific about what we write to the toml file. Instead of taking the whole app config and overwriting the toml, the idea is to load the current toml and patch with just the new values.
WHAT is this pull request doing?
patchAppConfigurationFile
writeAppConfigurationFile
to usepatchAppConfigurationFile
with more specific patches.writeAppConfigurationFile
is now used only duringlink
.How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist