Fix dev session refresh token

isaacroldan commented 1 week ago

WHY are these changes introduced?

Dev session wasn't processing 401 errors, which means it wasn't refreshing tokens and the session crashed once the token expires.

Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2295

WHAT is this pull request doing?

If a 401 error is received, instead of printing it to the terminal, re-throw it so that the retry system can catch it and refresh the token.
Update uncaughtException to render fatal errors. Some errors thrown inside some contexts aren't caught by the main error handler and are instead processed by the uncaughtException handler. It now knows how to render fatal errors.
Some small UX improvements for normal errors in dev-session.

How to test your changes?

Start dev
Force a logout on your session (ping me on how to do this)
Wait 1 min
Make a change in your app -> see the error. In this case, since it was a forced logout, the CLI can recover from it and the dev-session will end.
To test that the refresh works: leave a dev session open for more than 1h

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes

github-actions[bot] commented 1 week ago

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	72.08% (-0.04% 🔻)	8364/11603
🟡	Branches	68.56% (-0.01% 🔻)	4054/5913
🟡	Functions	71.38% (-0.09% 🔻)	2195/3075
🟡	Lines	72.45% (-0.03% 🔻)	7908/10915

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------- | :------- | :------------------------------------------------------------- | :------------------------------------------------------------- | | 🔴 |

`...` / dev-session.ts

|

4.17% (-0.25% 🔻)

| 0% |

6.67% (-1.03% 🔻)

|

4.62% (-0.3% 🔻)

| | 🔴 |

`...` / app-management-client.ts

|

20.33% (-0.34% 🔻)

| 9.52% |

22.11% (-0.48% 🔻)

|

18.75% (-0.17% 🔻)

|

Test suite run success

1894 tests passing in 866 suites.

Report generated by 🧪jest coverage report action from 0016847eec47c07950a3fd810863ca080e9315b5

Shopify / cli