Open gordonhirsch opened 1 week ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 72% (-0.03% π») |
8351/11599 |
π‘ | Branches | 68.42% (-0.04% π») |
4038/5902 |
π‘ | Functions | 71.34% (+0.02% πΌ) |
2193/3074 |
π‘ | Lines | 72.37% (-0.04% π») |
7897/10912 |
1890 tests passing in 865 suites.
Report generated by π§ͺjest coverage report action from e35b8aba785f7356269a0f15dc776fef2b23bb45
WHY are these changes introduced?
Improve accuracy of the CLI error count SLOs by marking GraphQL failures due to internal server errors as
expected
.Internal server errors are recorded as unexpected events by the back-end that generates them. From the point of view of the CLI, we expect such errors will occur and we communicate the failure to the user. That's all we can do, so they should not count against the error count SLOs
WHAT is this pull request doing?
Uses a common type to identify all GraphQL. Interrogates the error response info to determine if the error is internal, and reports the error as expected if it is internal.
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist