Closed shauns closed 1 week ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @shauns and the rest of your teammates on Graphite
We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.
We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
main
you might see odd diffs, rebase main
into this branch.We found no diffs with existing type declarations
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π‘ | Statements | 71.33% (-0.44% π») |
8463/11864 |
π‘ | Branches | 67.9% (-0.33% π») |
4105/6046 |
π‘ | Functions | 70.9% (-0.41% π») |
2220/3131 |
π‘ | Lines | 71.77% (-0.47% π») |
8004/11153 |
1917 tests passing in 870 suites.
Report generated by π§ͺjest coverage report action from 3925050e2e74f4cbf38b5a68f39464d1fa09068e
WHY are these changes introduced?
Internal to Shopify, the CLI needs to support the new dev server infrastructure and hostnames for local development environments.
For any non-Shopifolk: there's no difference, it's an internal adjustment.
WHAT is this pull request doing?
Adds a copy of the DevServer library (with permission) and use it for FQDNs during local dev.
How to test your changes?
Run
SHOPIFY_SERVICE_ENV="local" p shopify app info --path=<path to an app> --verbose
You'll see the CLI exit, because the first thing it wanted to connect locally to wasn't there (probably
identity
). Confirm the error message and the URL it was trying to connect to.Checklist
Measuring impact
How do we know this change was effective? Please choose one: