github-actions[bot]
commented
1 week ago Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 71.78% | 8458/11784 |
| 🟡 | Branches | 68.22% | 4103/6014 |
| 🟡 | Functions | 71.31% | 2220/3113 |
| 🟡 | Lines | 72.24% | 7999/11073 |
Show files with reduced coverage 🔻
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines |
| :----------------------------------------------------------------------------------------------------------------------------------------------------: | :---------------------------------------------------------------------------------------------------------- | :----------------------------------------------------------- | :---------------------------------------------------- | :-------- | :----------------------------------------------------------- |
| 🟢 | `...` / ConcurrentOutput.tsx
| 98.39% (-1.61% 🔻)
| 88% (-4% 🔻)
| 100% | 98.36% (-1.64% 🔻)
|
Test suite run success
1917 tests passing in 870 suites.
Report generated by 🧪jest coverage report action from 08f3ddba1fd0d026239357ecfdb7df6123da07d8
jeffcharles
WHY are these changes introduced?
The function-runner version has an Javy QuickJS provider that matches what's being used in production. I'm already in here so may as well update Javy as well. This should also slightly de-risk future updates to Javy because there will be fewer changes (compared to updating across multiple versions at the same time).
WHAT is this pull request doing?
Updates the versions the CLI will download to the latest versions of Javy and the function-runner.
How to test your changes?
rm -r packages/app/dist/cli/services/bin/(clear out any cached downloaded binaries)pnpm shopify app function build --path <path_to_function_extension>(downloads and runs Javy)echo "{}" | pnpm shopify app function run --path <path_to_function_extension>(downloads and runs function-runner)Measuring impact
How do we know this change was effective? Please choose one:
Checklist