search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.48k stars 3.32k forks source link

[Global setting] Make Content container shadow to appear below section #1070

Open melissaperreault opened 2 years ago

melissaperreault commented 2 years ago

Expectation

A follow up for https://github.com/Shopify/dawn/pull/1050

Video reference

ludoboludo commented 2 years ago

Ideally we're wanting to show the shadow only when the vertical offset is positive, is that right ?

melissaperreault commented 2 years ago

Ideally we're wanting to show the shadow only when the vertical offset is positive, is that right ?

@ludoboludo Yes, because anyway the negative to show at the opposite won't display, like on Image with text, the shadow is always under unless it is set to overlap, where it overlaps the media.