search

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.48k stars 3.32k forks source link

[Email signup] Non full-width missing bottom margin #1125

Open svinkle opened 2 years ago

svinkle commented 2 years ago

Describe the current behavior For the Email signup section, toggling Make section full width off seems to remove all bottom margin.

Describe the expected behavior I assume there'd be some margin here to add space?

Version information (Dawn, browsers and operating systems)

Possible solution

Additional context/screenshots

Email signup section sits directly against footer section without any spacing in between.
nicklepine commented 2 years ago

This will be fixed with https://github.com/Shopify/dawn/pull/1110 we're adding a margin setting for the footer.