Featured product section on Password page - Errors - Githubissues

Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.

Other

2.48k stars 3.32k forks source link

Featured product section on Password page - Errors #1144

Open KaichenWang opened 2 years ago

KaichenWang commented 2 years ago

Describe the current behavior

JS errors occur with Featured product section on Password page when:

Trying to open media modal (zoom)
Trying to add to cart

Describe the expected behavior

Respective interactions should not cause JS error
Or better error handling can be implemented

Version information (Dawn, browsers and operating systems)

Dawn Version: 2.5.0
Chrome Version 96.0.4664.110
macOS Version 12.1

Possible solution

n/a

Additional context/screenshots

Opening media modal

Screen Shot 2022-01-10 at 2 53 01 PM

Adding to cart

Screen Shot 2022-01-10 at 2 53 09 PM

sofiamatulis commented 2 years ago

Note: It is expected that the Add to cart won't work on the password page. More context here:https://github.com/Shopify/dawn/pull/1091#discussion_r781544877