Open sofiamatulis opened 2 years ago
Related: original comment by @ludoboludo
When enabling the slider, there is a change in spacing on tablet that is happening. I'm not sure if we want to actually fix it or wait until we add the slider on tablet 🤔 video
Related issue comment: https://github.com/Shopify/dawn/issues/1360#issue-1137509599
I wonder here if we should be adding the slider on tablet as well. It took me a few seconds to realize that it's a section on which Enable swipe on mobile means only on mobile but not on tablet. When others, like feat. collection, blog posts do.
Could be a follow up but I think should be shipped in the same them update/upgrade. Otherwise it makes for an odd experience. But maybe it would have too much of an impact on existing merchants. Unless we have a breaking change included and then we don't need to worry about it
https://github.com/Shopify/dawn/pull/1352#discussion_r805025142
Describe the enhancement you'd like Currently all sections that have
enable slider on mobile
setting affect mobile and tablet. Except for multicolumn. It only affects mobile.When we are using the label mobile , we are affecting mobile and tablet. However I did notice that multicolumn only has the slider ("enable slider on mobile" setting) on mobile and not on tablet.
This can be confusing for merchants since everywhere else mobile affects tablet as well except for here. In addition to that, using the label mobile would be confusing if not consistent across the sections. Original comment: https://github.com/Shopify/dawn/pull/1352#issuecomment-1041924443
Describe alternatives you've considered Keep it this way and add a helper text?
cc @katycobb @wiktoriaswiecicka