Shopify / dawn

Shopify's first source available reference theme, with Online Store 2.0 features and performance built-in.
Other
2.52k stars 3.39k forks source link

Account Page: Order History table shows total price in the selected currency, instead of the actual order currency #1613

Open muriloshimizu opened 2 years ago

muriloshimizu commented 2 years ago

Describe the current behavior When a customer goes to the account page and views the order history table, all the order totals are in the currency of the currently selected country (Country selector, eg: added in the footer). The main problems I see:

1) The order happened in the past, with transactions on a currency that was locked when the order happened. It shouldn't change currency based on what you select on any language/currency selector.

2) The currency symbol and iso codes change, but the value isn't actually converted. Example: $10 USD order placed, then we change the country to Spain... and it will display €10 EUR. This is very misleading and frustrating, specially in cases where the exchange rates aren't in favour of the customer.

Images below:

Screen Shot 2022-04-12 at 1 59 09 pm Screen Shot 2022-04-12 at 1 59 53 pm Screen Shot 2022-04-12 at 2 14 44 pm

On the order page, the currency is correct.

Screen Shot 2022-04-12 at 2 17 38 pm

I believe this isn't a dawn-specific issue, more like a liquid/shopify issue... not sure.

Describe the expected behavior Order currency should be locked and displayed on the order history table (accounts page) according to the actual currency it was placed on.

Version information (Dawn, browsers and operating systems)

richilton commented 1 year ago

I have just hit the same problem. My workaround was to render the amounts as follows:

{{ order.total_price | money_without_currency }} {{ order.currency }}

This outputs something like "19.99 GBP".

However, order.currency is not mentioned in the Liquid documentation, so I'm not sure if it is safe to use. And it isn't very elegant – the currency symbol isn't rendered, for example.

arnoldoosterom commented 1 year ago

The company I work with started to use Global-E (Shopify Markets Pro) and their Q&A is also telling me this is a problem. Strange that Shopify again completes ignores this.

KhangNguyen303 commented 11 months ago

Wow they did not resolve it yet

EranBendheim commented 2 months ago

Thank U :)